Discussion:
Patch "fs: Add a missing permission check to do_umount" has been added to the 3.14-stable tree
g***@linuxfoundation.org
2014-10-19 23:18:57 UTC
Permalink
This is a note to let you know that I've just added the patch titled

fs: Add a missing permission check to do_umount

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
fs-add-a-missing-permission-check-to-do_umount.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
From a1480dcc3c706e309a88884723446f2e84fedd5b Mon Sep 17 00:00:00 2001
From: Andy Lutomirski <***@amacapital.net>
Date: Wed, 8 Oct 2014 12:32:47 -0700
Subject: fs: Add a missing permission check to do_umount

From: Andy Lutomirski <***@amacapital.net>

commit a1480dcc3c706e309a88884723446f2e84fedd5b upstream.

Accessing do_remount_sb should require global CAP_SYS_ADMIN, but
only one of the two call sites was appropriately protected.

Fixes CVE-2014-7975.

Signed-off-by: Andy Lutomirski <***@amacapital.net>
Signed-off-by: Greg Kroah-Hartman <***@linuxfoundation.org>

---
fs/namespace.c | 2 ++
1 file changed, 2 insertions(+)

--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1365,6 +1365,8 @@ static int do_umount(struct mount *mnt,
* Special case for "unmounting" root ...
* we just try to remount it readonly.
*/
+ if (!capable(CAP_SYS_ADMIN))
+ return -EPERM;
down_write(&sb->s_umount);
if (!(sb->s_flags & MS_RDONLY))
retval = do_remount_sb(sb, MS_RDONLY, NULL, 0);


Patches currently in stable-queue which might be from ***@amacapital.net are

queue-3.14/fs-add-a-missing-permission-check-to-do_umount.patch

Loading...